Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter type for the execute method in AdminActionService #38

Closed
jakub-groncki opened this issue Jul 28, 2022 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@jakub-groncki
Copy link

jakub-groncki commented Jul 28, 2022

In Vin\ShopwareSdk\Service\AdminActionService the $data parameter has type array:

class AdminActionService extends ApiService
{
    public function execute(string $method, string $path, array $data = [], array $headers = []): ApiResponse
    {
        // ...
    }
        // ...
}

But this is wrong considering the fact that some endpoints consume octet-streams.

This would need to be changed to array|string or just left as mixed by default, depending on the target PHP version.

@vienthuong
Copy link
Owner

Hi @jakub-groncki
Thanks for pointing it out, I will update it soon

@vienthuong vienthuong self-assigned this Jul 29, 2022
@vienthuong vienthuong added the enhancement New feature or request label Jul 29, 2022
@vienthuong
Copy link
Owner

I updated it in the lastest version, feel free to reopen ticket if you have any issue
And also I added a new MediaService, now you can use the MediaService instead
#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants