-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devise’s authenticate block breaks previews #445
Comments
I got the exact same issue |
@nicieja thanks for bringing this to my attention - I don't use Devise personally so I haven't run into this before, but I can replicate it with the repo you provided so just looking into it now. Will hopefully have a fix up soon 👍 |
Hey @nicieja @guillaumebriday-pa - I believe I have a fix for this now in PR #450. It works for me in the It is a bit of a hack to be honest - the issue you are seeing is actually being caused by a workaround for another bug. But if this works for now then I'll ship it for now and hopefully spend a bit of time on unpicking the actual root cause of the problem when I have a little more time. I'm going to go a little more testing but once I'm happy (and unless I hear back that it is still causing issues for either of you) I'll merge it in and get it out in the next release (which will be v1.0.1). |
(@nicieja as an aside, Changepack looks very interesting! I'm keen to dig in a bit more when I get a chance 😊) |
The fix actually works for me as well! Thank you for your reactivity! 🙏 |
@guillaumebriday-pa great, thanks for letting me know - I'll merge that in now 👍 |
Awesome 🙏 , can you release the 2.0.1? |
@guillaumebriday-pa @nicieja 2.0.1 is now out that includes the fix for this. Thanks for your help! |
@allmarkedup Didn’t look at GitHub yesterday but I can confirm that the fix works for me too. Thanks!
Glad you like it! 🙏 |
Describe the bug
Am I the only one who gets
undefined method 'authenticate!' for nil:NilClass
when I use Devise’sauthenticate
block in routes like this: https://github.com/changepack/changepack/blob/5d27756550051dd6adafe52e8ecc83186bf12ea9/config/routes.rb#L9To Reproduce
Steps to reproduce the behavior:
git clone git@github.com:changepack/changepack.git
Expected behavior
I expect to see the component previewed. When I comment the
authenticate
block out, everything works perfectly.Version numbers
Please complete the following information:
The text was updated successfully, but these errors were encountered: