Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] infinite loops in d35e system #582

Closed
psedonatural opened this issue Mar 3, 2024 · 1 comment
Closed

[BUG] infinite loops in d35e system #582

psedonatural opened this issue Mar 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@psedonatural
Copy link

Describe the bug
Infinite loop with attack rolls in system D35E and causes stackoverflow.
WIth default d35e system, it throws an error reaches maximum 3 stacks:
RangeError: Error thrown in hooked function 'createChatMessage' for hook 'preCreateChatMessage'. Maximum call stack size exceeded

If libWrapper is enabled, there is no maximum stacks restriction and the infinite loop may lead to a crash.

To Reproduce
Steps to reproduce the behavior:

  1. With D35E system, only simple calendar enabled.
  2. open an actor card and give him a weapon
  3. open(edit) the weapon item card and click on the "create attack" on the title bar.
  4. back to the actor card, summary tab, use the attack action that you just created.
  5. check the error

Expected behavior
native D35E attack rolls.

Screenshots
If applicable, add screenshots to help explain your problem.
with no other mods
image
with libWrapper enabled
image

Foundry Information

  • Foundry Version: [v11.315] up2date
  • Game System: [3.5E SRD v2.4.3] up2date
  • Simple Calendar Version: [2.4.3] up2date
  • Simple Calendar Configuration: [default]

Browser (please complete the following information):

  • Browser [chrome]

Additional context
Add any other context about the problem here.

@psedonatural psedonatural added the bug Something isn't working label Mar 3, 2024
@vigoren
Copy link
Owner

vigoren commented Mar 8, 2024

This has been fixed in version 2.4.8!

@vigoren vigoren closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants