Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/filter and sort #98

Merged
merged 48 commits into from
Jul 25, 2016
Merged

Feature/filter and sort #98

merged 48 commits into from
Jul 25, 2016

Conversation

jimdebeer
Copy link
Contributor

  • added full sort functionality
  • almost every function is optimised
  • fixed all bugs with filters
  • adheres to standard js sort

Jim de Beer added 30 commits July 19, 2016 19:09
added failing case
af4739e
start of filter sort
f8f8cba
added fix for filter
c530819
added more complicated tests
8387e81
more compelte tests
4fcf42e
perf improvement for sort add
2309258
clean up sort add
e4b0ee2
clean up filters
bbd203c
remove tests
9534f90
added remove tests
abfd6fe
added fix
2768075
restructure order
8994caa
added update method
dcb3c88
cleaner structure
ef01e64
resort works, only needs perf optmization
c5988dd
clean up filters (needs lots of work still in perf)
96e65c4
remove logs
2586381
added tests for same bounds
f455d2d
add start of instances test
3657182
individual update inherit
a8d7b43
added instances update for resort
05a5adc
sort allways resorts
22e2e9b
added filter double updates closes #96
83dd082
added keyType tests, removed logs, fixed keyType and filter problem
07d63c5
removed wrong push statement
ce37eff
increase coverage
80bcc22
back to 100% coverage
a3e1c15
added method for sort accepting -1, 1, 0 as response closes #79
1ff3892
added test for custom sort
a61598e
renamed method to exec
f0ed69f
@jimdebeer jimdebeer self-assigned this Jul 25, 2016
@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited

Coverage Status

Coverage increased (+0.08%) to 100.0% when pulling a2a182f on feature/filterAndSort into 8145904 on master.

@jimdebeer
Copy link
Contributor Author

ignore bithound

@jimdebeer jimdebeer merged commit 56cfde9 into master Jul 25, 2016
@jimdebeer jimdebeer deleted the feature/filterAndSort branch July 25, 2016 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimdebeer jimdebeer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimdebeer @coveralls