Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] configurable force_pull_image for the app_image #2

Open
lhoss opened this issue Dec 6, 2017 · 2 comments
Open

[Feature Request] configurable force_pull_image for the app_image #2

lhoss opened this issue Dec 6, 2017 · 2 comments

Comments

@lhoss
Copy link

lhoss commented Dec 6, 2017

Would be useful to support configuring the marathon' docker container field force_pull_image (and keep the default false).

This would require the field here , plus some more config handling code:

https://github.com/vigsterkr/marathonspawner/blob/master/marathonspawner/marathonspawner.py#L248
 def start(self):
        docker_container = MarathonDockerContainer(
            ...
            force_pull_image=self.force_pull_image,
@vigsterkr
Copy link
Owner

@lhoss sure thing if you can specify more what is required for you i can add it right away... one question though: are you using this internally? or what's the usecase? :) would be great if you could share

@lhoss
Copy link
Author

lhoss commented Dec 8, 2017

@vigsterkr great to hear!
we plan to use Jupyter-Hub on our Mesos/Marathon platform, but no time yet to get really into it, so not sure yet what other features of marathon app configs would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants