Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should not be a subdistro #63

Open
lsolesen opened this issue Jun 8, 2015 · 6 comments
Open

This should not be a subdistro #63

lsolesen opened this issue Jun 8, 2015 · 6 comments

Comments

@lsolesen
Copy link
Member

lsolesen commented Jun 8, 2015

This is only specific to vih.dk at the moment, and right now nothing is being done to make reusable content. Therefore This should not be a subdistro. All content from .info and .install could be moved to vih_deploy.

@mglaman
Copy link
Contributor

mglaman commented Jun 8, 2015

What about tests, etc? Would those be part of the deploy? or keep it as is, just not "si vih_dk"

@lsolesen
Copy link
Member Author

lsolesen commented Jun 8, 2015

I would just keep this repository as the main build repository also keeping the tests. but instead of "si vih_dk" do "si panopoly" and enable vih_deploy manually in the tests.

@mglaman
Copy link
Contributor

mglaman commented Jun 9, 2015

I think that makes sense, follows more closely to how the other sites are setup.

@mglaman
Copy link
Contributor

mglaman commented Sep 29, 2015

So to make a case against this, we needed to patch Panopoly Core in #92, which is a patch to include a patch. If not using vih_dk as root profile, fixes would require a patch to Panopoly to include Panopoly Core patch.

Edge case is low, but one thing to consider.

@mglaman
Copy link
Contributor

mglaman commented Oct 1, 2015

@lsolesen I vote for postponing this for a little but. Mostly because of fix required for #92 and trying to patch all the way down. If we can get https://www.drupal.org/node/2576819 RTBC and committed that'd streamline this.

@lsolesen
Copy link
Member Author

lsolesen commented Oct 1, 2015

@mglaman Moving this to a later mlestone.

@lsolesen lsolesen modified the milestones: 7.x-1.6 Integrate finally with Panopoly, 7.x-1.3 Cleaning up Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants