New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This should not be a subdistro #63
Comments
What about tests, etc? Would those be part of the deploy? or keep it as is, just not "si vih_dk" |
I would just keep this repository as the main build repository also keeping the tests. but instead of "si vih_dk" do "si panopoly" and enable vih_deploy manually in the tests. |
I think that makes sense, follows more closely to how the other sites are setup. |
So to make a case against this, we needed to patch Panopoly Core in #92, which is a patch to include a patch. If not using vih_dk as root profile, fixes would require a patch to Panopoly to include Panopoly Core patch. Edge case is low, but one thing to consider. |
@lsolesen I vote for postponing this for a little but. Mostly because of fix required for #92 and trying to patch all the way down. If we can get https://www.drupal.org/node/2576819 RTBC and committed that'd streamline this. |
@mglaman Moving this to a later mlestone. |
This is only specific to vih.dk at the moment, and right now nothing is being done to make reusable content. Therefore This should not be a subdistro. All content from .info and .install could be moved to vih_deploy.
The text was updated successfully, but these errors were encountered: