Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery.browser() removed in jQuery 1.9 and still used in Init function of jquery-comments #39

Closed
Glursh opened this issue Feb 23, 2016 · 1 comment

Comments

@Glursh
Copy link

Glursh commented Feb 23, 2016

Hi !

When looking on jQuery changes, I saw that browser() function has been removed in version 1.9.

However, this function is still used in the last release of jquery-comments to detect mobile device, in Init function, line 200.

What's your opinion about the fact that jquery-comments is compatible with version 1.9 of jQuery ?
(Dependencies say jQuery >= 1.9.0)

(Sorry for my English and thanks for your work)

Yannick

@jjtykkyl
Copy link
Contributor

jquery-comments is not dependent on $.browser() function as it defines the function if it wasn't available. If you look at the initialization, you can see that the function is defined as follows:

jQuery.browser = jQuery.browser || {}

Initialising an empty dictionary will act as a fallback if the jQuery version used did not provide the jQuery.browser -function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants