Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't upgrade due to .Net Standard dependency #55

Closed
ramedey opened this issue Mar 6, 2018 · 3 comments
Closed

Can't upgrade due to .Net Standard dependency #55

ramedey opened this issue Mar 6, 2018 · 3 comments

Comments

@ramedey
Copy link

ramedey commented Mar 6, 2018

I got stuck with an older version because my solution does not support .Net Standard.

Would it be possible to add a dependency group in the nuspec file that targets .NET Framework 4.5 without .Net Standard?

I believe it would be something like this (not 100% sure though):

    <dependencies>
      <group targetFramework=".NETFramework4.5">
         <dependency id="Newtonsoft.Json" version="10.0.3" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard1.2">
        <dependency id="NETStandard.Library" version="1.6.1" exclude="Build,Analyzers" />
        <dependency id="Newtonsoft.Json" version="10.0.3" exclude="Build,Analyzers" />
      </group>
    </dependencies>
@Sebazzz
Copy link

Sebazzz commented Nov 2, 2018

No, you'd need to multitarget, like this:

<TargetFrameworks>netstandard1.2;net45</TargetFrameworks>

@Viincenttt
Copy link
Owner

Viincenttt commented Feb 6, 2019

Fixed in development-2.0.3.0 branch, thanks @Sebazzz

@Viincenttt
Copy link
Owner

The issue should now be resolved in version 2.0.3.0, which is available for download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants