Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested to random ip in FetchOne. #4

Open
starsz opened this issue Aug 19, 2019 · 3 comments
Open

Suggested to random ip in FetchOne. #4

starsz opened this issue Aug 19, 2019 · 3 comments

Comments

@starsz
Copy link

starsz commented Aug 19, 2019

Hello. I think your FetchOne function always return the first ip in cache is not perfect.Because we can use dns to do some load-balance.

image

So, i think you can random your ip in return. Or create another function to return a random Ip.

@mstrYoda
Copy link

@karlseguin do you consider to accept a pr for this change?

@karlseguin
Copy link
Contributor

I don't have access to this repo anymore. I don't know if it's being maintained by anyone. If I was using it, I'd just fork it and maintain my own.

@starsz
Copy link
Author

starsz commented Feb 27, 2020

Yeah! That is what I do.

You can see my repo: https://github.com/starsz/dnscache , and I added FetchRandomOne and FetchRandomOneString function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants