Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in implementing running-friendly features? #26

Closed
davidedelvento opened this issue Jul 14, 2017 · 2 comments
Closed

Interest in implementing running-friendly features? #26

davidedelvento opened this issue Jul 14, 2017 · 2 comments

Comments

@davidedelvento
Copy link

I run (and I mean with my feet, not just I run software on a computer :-) ) and I am considering to use viking to analyze my running data.

Problem is, most of of the things I need aren't implemented. I am interested in implementing them myself and submitting PRs, however before I go to that trouble, I'd like to know if there's chance for them to be merged, or if there is no interest in having running-friendly features in viking.

I guess the answer would be "it depends on the feature and how is implemented", so let's assume it's implemented with the same standard as the rest of the codebase, and I will submit two more specific issues as examples.

@rnorris
Copy link
Collaborator

rnorris commented Jul 27, 2017

Running friendly features in Viking will be gladly accepted.

Of course the more general purpose - like the graph smoothing - the better.

ATM I don't have too much spare time available to respond in more depth about the other Issues - in principle they look fine and sensible.

But I'd note a word of caution about the amount of effort required for 'plot extensions field in gpx data' since Viking doesn't handle really handle any extensions (i.e. fully supporting GPX 1.1). So I'd expect you need to create/extend the framework within Viking to handle such extensions and so your specific fields can be dealt with. Hopefully such a base would then lend itself for adding support for Heart Rate data etc... (see https://sourceforge.net/p/viking/feature-requests/96/ and https://sourceforge.net/p/viking/bugs/131/

@davidedelvento
Copy link
Author

Great thanks, see PR #33 (and #32 however that is generic, not runner-specific)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants