Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: see dots when apply opacity to pencil #129

Closed
lhvan opened this issue Oct 2, 2018 · 2 comments
Closed

bug: see dots when apply opacity to pencil #129

lhvan opened this issue Oct 2, 2018 · 2 comments

Comments

@lhvan
Copy link

lhvan commented Oct 2, 2018

problem:
https://ibb.co/ibWfEK
When i set the globalAlpha to set opacity in pencil, we will see dots in drawn line. How can i remove them.

@viliusle
Copy link
Owner

viliusle commented Oct 2, 2018

You can remove ctx.beginPath(); inside loop in /src/js/tools/pencil.js, function render_antialiased(), it is responsible for that issue. (But please dont)

But i don't recommend doing it, because performance different is HUGE. It will slow down system, and user will not be able to draw circles, but end up in something like rectangles, because of poor performance. Basically pencil tool creates lots of vectors.

Other fix could be change this tool to draw to empty image directly, like erase is doing.

@lhvan
Copy link
Author

lhvan commented Oct 4, 2018

@viliusle I got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants