Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom menu item chops off slightly... #70

Closed
First-Broadcast opened this issue Sep 17, 2013 · 7 comments
Closed

Bottom menu item chops off slightly... #70

First-Broadcast opened this issue Sep 17, 2013 · 7 comments

Comments

@First-Broadcast
Copy link

The bottom menu item seems to appear full size but then you see it reduce in size after loading on mobile view. It also doesn't seem to matter how many menu items I use - it does it on 2 up to 6 items that I've tested.

I also realise this is really a noob question to ask but I've tried restyling the hamburger and cannot get it to change from white no matter if I change the image to have a texture on it or anything else. I can obviously change the colour of the bars by changing the background colour. I was wondering if there's something in the js overriding the image to make it white?

@skowronek
Copy link

I have reproduced this as well. The issue is with var savedHeight being set incorrectly under certain situations (at least in mine now.) The call (nav.inner[i].offsetHeight;) is not pulling in the correct height of the wired up element so the max-height is set too short.

@arielsalminen
Copy link
Owner

@skowronek What are these certain situations? If you share a bit more details+code I can start investigating how to fix this :)

@skowronek
Copy link

I'll put something together today when i get into the office. thanks for the quick response on this and the other issue. I'd fix it myself if I had the time. I may end up doing that anyway in trying to get it to work right.

@First-Broadcast
Copy link
Author

I'd love to see the solution as well - look forward to it :-)

@skowronek
Copy link

We figured out what the deal was. Someone had put a top margin on the inner UL to the DIV that the menu was wired up against. Once we removed the top/bottom margins (aren't included with the offsetheight), the correct height for the DIV could be calculated.

@eliawk
Copy link

eliawk commented Oct 22, 2013

i've the same problem adding some padding / margin to <li>, the last elements of menu are not shown.

<nav>
  <ul>
    <li>   <--- these one
    <li> 

without margin/padding the height is correct.

@First-Broadcast
Copy link
Author

Awesome, thanks for all the responses - that was driving me crazy! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants