Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airline_term built-in vim terminal's tag isn't defined for most themes #180

Closed
illia-danko opened this issue Jul 22, 2019 · 1 comment
Closed

Comments

@illia-danko
Copy link

illia-danko commented Jul 22, 2019

Hi. I believe is's better to define the airline_term in the most popular themes (or even in all of them) in order to provide a nicer user experience. For instance, we could pick the same settings as for airline_c: found that it's a pleasure to look at with my solarized light theme:

Before (use the default airline_term):
airline_terminal_before

After patching:

let s:saved_theme = []

let g:airline_theme_patch_func = 'AirlineThemePatch'
function! AirlineThemePatch(palette)
    for colors in values(a:palette)
        if has_key(colors, 'airline_c') && len(s:saved_theme) ==# 0
            let s:saved_theme = colors.airline_c
        endif
        if has_key(colors, 'airline_term')
            let colors.airline_term = s:saved_theme
        endif
    endfor
endfunction

and applying the same colors as for airline_c I have:
airline_terminal_after
which is arguably (but likely) much better for eyes.

@illia-danko illia-danko changed the title airline_term tag for built-in vim terminal isn't defined in most themes airline_term built-in vim terminal's tag isn't defined in most themes Jul 22, 2019
@illia-danko illia-danko changed the title airline_term built-in vim terminal's tag isn't defined in most themes airline_term built-in vim terminal's tag isn't defined for most themes Jul 22, 2019
@chrisbra
Copy link
Member

I have refrained to add the airline_theme group to the existing themes mainly because I am not good at theming and do not really know what would look good per theme. However I am not opposed to add custom airline_term sections to specific themes. PRs appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants