Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually re-define functions under function module with proper type definitions #44

Open
lambdalisue opened this issue Jul 10, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lambdalisue
Copy link
Member

lambdalisue commented Jul 10, 2021

Functions under the function/_generated.ts module are produced programmatically without type definitions. So we need contributors helps to re-define these manually with proper type definitions like function/buffer.ts.

How to (partially) contribute to this issue

  1. Add (or update) a module in function and write proper function definitions
    • Write proper type definitions
    • Write proper document comments
    • Write unit tests for the functions
  2. Add the module to _manual.ts if missing
  3. Execute make gen to re-generate _generated.ts so that manually defined functions are removed from _generated.ts
  4. Create a PR for that and link to this issue

Please use definitions of the following while those are the minimum versions which denops.vim support

@lambdalisue lambdalisue added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 10, 2021
@lambdalisue
Copy link
Member Author

lambdalisue commented Jul 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants