Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw で警告が大量に出る #826

Closed
mattn opened this issue Feb 16, 2016 · 18 comments
Closed

mingw で警告が大量に出る #826

mattn opened this issue Feb 16, 2016 · 18 comments

Comments

@mattn
Copy link
Member

mattn commented Feb 16, 2016

https://gist.github.com/mattn/6542c52e98dce6923fc3

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

char* と char_u* は許して欲しい感ある

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

os_mswin.c がまだ。あと言語拡張系はどうしても取れない。

@k-takata
Copy link
Member

https://gist.github.com/mattn/6542c52e98dce6923fc3#file-gistfile1-diff-L523
ここ、コンマの後に空白を入れたほうがよいでしょう。(元がそうでしたが。)

@mattn mattn self-assigned this Feb 16, 2016
@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

os_mswin.c 済。残は

https://gist.github.com/mattn/cc9284dc20cb714f424b

言語拡張は放置で。

@k-takata
Copy link
Member

os_mswin.c 以外に対するパッチが消えているようです。

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

失礼しました。.oO(ブランチにコミットしたの忘れて git diff しちゃったなんて)

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

VCでビルドエラーになった。 → 直しed

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

あと3つ!

getchar.c: In function 'check_map':
getchar.c:5221:7: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
    if (len + 3 > mp->m_keylen)
       ^
undo.c: In function 'u_save_cursor':
undo.c:268:6: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Wstrict-overflow]
      || top >= bot
      ^
In file included from uninstal.c:21:0:
dosinst.h:456:1: warning: 'add_pathsep' defined but not used [-Wunused-function]
 add_pathsep(char *name)
 ^

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

YATTA! 警告消えた

@k-takata
Copy link
Member

https://gist.github.com/mattn/6542c52e98dce6923fc3#file-remove-warnings-diff-L267-L269
https://gist.github.com/mattn/6542c52e98dce6923fc3#file-remove-warnings-diff-L278
ここは、#ifdef __GNUC__ か何かで囲ったほうがいいです。VCでwarningが出るので。

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

なるほどあざます

@mattn
Copy link
Member Author

mattn commented Feb 16, 2016

疲れてきたので出しed

https://groups.google.com/forum/#!topic/vim_dev/-2lLZ5Z2cPM

@k-takata
Copy link
Member

@k-takata
Copy link
Member

@k-takata
Copy link
Member

patch 7.4.1339
Problem:    Warnings when building the GUI with MingW. (Cesar Romani)
Solution:   Add type cats. (Yasuhiro Matsumoto)

よく見ると、猫を追加したそうだw

@mattn
Copy link
Member Author

mattn commented Feb 17, 2016

ww

@koron
Copy link
Member

koron commented Feb 17, 2016

猫ってそれかw パッチの中見てもわからなかったから、なんなんだろって思ってたwww

@mattn
Copy link
Member Author

mattn commented Feb 18, 2016

一旦閉じますかね。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants