Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-syntax doesn't load after default vim syntax file #73

Closed
weavage opened this issue Aug 17, 2020 · 2 comments
Closed

python-syntax doesn't load after default vim syntax file #73

weavage opened this issue Aug 17, 2020 · 2 comments
Labels

Comments

@weavage
Copy link

weavage commented Aug 17, 2020

There seems to be a bug in the logic that detects previous syntax files here. On my Ubuntu machine with Vim 8, the default vim syntax file gets loaded first: /usr/share/vim/vim80/syntax/python.vim
This sets the '''b:current_syntax''' variable meaning the ptyhon-syntax script exits early due to the above lines. This results in several problems like missing highlights (#26 ) and commands missing (#61 ). Is this something specific to my setup or an actual bug?

@weavage weavage changed the title python-syntax doesn't after default vim syntax file python-syntax doesn't load after default vim syntax file Aug 26, 2020
@Congee
Copy link

Congee commented Sep 7, 2020

Yeah, the default one defines syntax keyword pythonTodo contained NOTE NOTES FIXME XXX TODO, while python-syntax highlights only FIXME XXX TODO

@nfnty nfnty added the question label Dec 2, 2020
@nfnty
Copy link
Member

nfnty commented Dec 2, 2020

This syntax plugin needs to be loaded before any others, otherwise it will just return without doing anything. Just like the builtin syntax files do.

@Congee That has nothing to do with op's problem. If you want to define more keywords, you can do so easily in your personal config. Or if there's some keyword you feel that everyone could benefit from you can open a PR.

@nfnty nfnty closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants