Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid regexp error for foo(*args).baz pattern #98

Closed
wants to merge 1 commit into from

Conversation

todesking
Copy link
Contributor

to reproduce:

foo(*args). # invoke omni completion here

@AndrewRadev
Copy link
Member

I'm afraid I'm not very familiar with the completion script, but from what I was able to understand, it seems like issue #120 manages to fix it in a slightly safer way. With this PR, I'm not entirely sure if GetRubyVarType could be called with something that's not quite \w+, like @foo or something, which is why I decided to merge in @sencer's solution.

In any case, thank you for your work, and sorry for the long wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants