Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR template #3

Open
romainl opened this issue May 3, 2020 · 5 comments
Open

Create a PR template #3

romainl opened this issue May 3, 2020 · 5 comments

Comments

@romainl
Copy link
Collaborator

romainl commented May 3, 2020

Reference: https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

@romainl romainl created this issue from a note in Call for colorschemes (To do) May 3, 2020
@habamax
Copy link
Collaborator

habamax commented Jan 17, 2022

  1. colors/tools/check_colors.vim should not have errors
  2. for each background attach screenshots of
    • colors/tools/sample_base.vim
    • colors/tools/sample_popupmenu.vim
    • colors/tools/sample_diff.vim
    • colors/tools/sample_messages.vim
  3. if a colorscheme supports termguicolors/GUI, t_Co=256 and/or t_Co=16 attach screenshots of pt2 per each

@habamax
Copy link
Collaborator

habamax commented Jan 17, 2022

example: habamax.vim

Background: light

GUI/termguicolors

sample_base.vim

image

sample_popupmenu.vim

image

sample_diff.vim

image

sample_messages.vim

image

t_Co=256

sample_base.vim

image

sample_popupmenu.vim

image

sample_diff.vim

image

sample_messages.vim

image

Background=dark

GUI/termguicolors

sample_base.vim

image

sample_popupmenu.vim

image

sample_diff.vim

image

sample_messages.vim

image

t_Co=256

sample_base.vim

image

sample_popupmenu.vim

image

sample_diff.vim

image

sample_messages.vim

image

@habamax
Copy link
Collaborator

habamax commented Jan 17, 2022

huh, window size should be enough to see colorcolumn or maybe adjust color_base.vim to have it at 40 or 50 col.

@habamax
Copy link
Collaborator

habamax commented Jan 17, 2022

@romainl too many screenshots or ok?

@romainl
Copy link
Collaborator Author

romainl commented Jan 17, 2022

We are talking colorschemes, here, so we need as many screenshots as possible :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants