Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated 8th.vim #13720

Merged
merged 2 commits into from
Dec 19, 2023
Merged

updated 8th.vim #13720

merged 2 commits into from
Dec 19, 2023

Conversation

ronaaron
Copy link
Contributor

Updated the 8th syntax file to correspond with the latest 8th release (23.09.01)

@dkearns
Copy link
Contributor

dkearns commented Dec 19, 2023

Thanks for the update.

There's some old Version 5 compatibility code that can be removed.

The following can be simplified to just the elseif branch.

if version < 600
syntax clear
finish
elseif exists("b:current_syntax")
finish
endif

if exists("b:current_syntax")
   finish
endif

and this guard can be removed altogether. This is briefly discussed at :help version6.txt in the Highlighting: section.

vim/runtime/syntax/8th.vim

Lines 423 to 424 in 91bb72d

if !exists("did_eighth_syntax_inits")
let did_eighth_syntax_inits=1

@ronaaron
Copy link
Contributor Author

OK, I've removed the obsolete code now.

@dkearns
Copy link
Contributor

dkearns commented Dec 19, 2023

Thanks Ron.

@chrisbra
Copy link
Member

thanks!

@chrisbra chrisbra merged commit 379df7c into vim:master Dec 19, 2023
29 checks passed
clason added a commit to clason/neovim that referenced this pull request Dec 19, 2023
runtime(8th): updated 8th syntax (vim/vim#13720)

* updated 8th.vim
* removed obsolete code

vim/vim@379df7c

Co-authored-by: ronaaron <ron@aaron-tech.com>
clason added a commit to neovim/neovim that referenced this pull request Dec 19, 2023
runtime(8th): updated 8th syntax (vim/vim#13720)

* updated 8th.vim
* removed obsolete code

vim/vim@379df7c

Co-authored-by: ronaaron <ron@aaron-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants