Remove some Win9x legacy from netrw built-in plugin #14732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One CI job fails since I did not rebuild the doc tags, I don't remember if that is necessary for PRs, if so let me know and I will fix |
|
no problem, I can fix it while merging it. |
k-takata
reviewed
May 8, 2024
|
Could you also update this part? vim/runtime/plugin/netrwPlugin.vim Line 38 in fb74575 |
|
@k-takata Fixed CR 👍 |
k-takata
reviewed
May 8, 2024
dkearns
reviewed
May 8, 2024
|
@dkearns fixed thanks, missed that due to the single quotes :) |
|
Thanks. I'll merge it. However it's strange that is hardcodes |
clason
added a commit
to clason/neovim
that referenced
this pull request
May 8, 2024
runtime(netrw): Remove and cleanup Win9x legacy from netrw closes: vim/vim#14732 vim/vim@1e34b95 Co-authored-by: Nir Lichtman <nir@lichtman.org>
clason
added a commit
to clason/neovim
that referenced
this pull request
May 8, 2024
runtime(netrw): Remove and cleanup Win9x legacy from netrw closes: vim/vim#14732 vim/vim@1e34b95 Co-authored-by: Nir Lichtman <nir@lichtman.org>
clason
added a commit
to neovim/neovim
that referenced
this pull request
May 8, 2024
runtime(netrw): Remove and cleanup Win9x legacy from netrw closes: vim/vim#14732 vim/vim@1e34b95 Co-authored-by: Nir Lichtman <nir@lichtman.org>
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
runtime(netrw): Remove and cleanup Win9x legacy from netrw closes: vim/vim#14732 vim/vim@1e34b95 Co-authored-by: Nir Lichtman <nir@lichtman.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The built-in file browsing plugin "netrw" contains a bunch of code that handles Windows 95/Win16 which are not supported by modern versions of Vim
Solution: Remove some legacy code/documentation from "netrw"