Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectWrite: Fix vertical alignment when 'linespace' is not 0 #4137

Closed
wants to merge 1 commit into from

Conversation

k-takata
Copy link
Member

After 8.1.1009 (#4116), the vertical alignment of DirectWrite became slightly
different from GDI. This is because he DirectWrite code didn't take 'linespace' into
account. This fixes the alignment when 'linespace' is not 0.

After 8.1.1009 (vim#4116), the vertical alignment of DirectWrite became slightly
different from GDI. This is because DirectWrite didn't take 'linespace' into
account. This fixes the alignment when 'linespace' is not 0.
@codecov-io
Copy link

Codecov Report

Merging #4137 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
- Coverage   79.23%    79.2%   -0.04%     
==========================================
  Files         105      105              
  Lines      141180   141180              
==========================================
- Hits       111870   111826      -44     
- Misses      29310    29354      +44
Impacted Files Coverage Δ
src/gui_beval.c 55.02% <0%> (-7.43%) ⬇️
src/window.c 82.95% <0%> (-0.64%) ⬇️
src/message.c 76.45% <0%> (-0.25%) ⬇️
src/gui_gtk_x11.c 48.18% <0%> (-0.2%) ⬇️
src/gui.c 57.94% <0%> (-0.16%) ⬇️
src/term.c 60.37% <0%> (-0.16%) ⬇️
src/undo.c 83.22% <0%> (-0.07%) ⬇️
src/screen.c 80.32% <0%> (-0.03%) ⬇️
src/channel.c 83.43% <0%> (+0.07%) ⬆️
src/ex_cmds2.c 84.98% <0%> (+0.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61be376...9b40505. Read the comment docs.

@brammool brammool closed this in 60ebd52 Mar 21, 2019
@k-takata k-takata deleted the dwrite-adjust-linespace branch March 22, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants