add fish syntax highlighting

[aeosynth]

fish is a somewhat popular shell, and it would be nice if syntax highlighting were supported by default

is there a process for adding new languages to the default runtime?

[chrisbra]

Someone, who already maintains a fish syntax script should state, the he wants to distribute his syntax script with vim. idealy the license allows us to distribute it (i think the vim license would be preferable). Do you know such a script (or perhaps even maintain such one)?

[kopischke]

Just in case nobody more qualified steps forward: I have recently forked the excellent, but unmaintained (the most up to date fork just integrates pending pull requests) vim-fish and started updating it (private branch, not pushed yet). I’m sure I am not the most qualified person to do so, but I would be willing to maintain it, or a syntax subset, for the Vim runtime if nobody else does.

[aeosynth]

@kopischke no one else seems interested, can you publish your code?

[OJFord]

It would be great if this could be added. I found this issue by trying to work through a mess of forks and determine which would be best to install. @wilriker and @fingerblaster have the most recently updated forks - I wonder if there's any interest there in maintaining an 'official' fork?

[wilriker]

On the one hand I'd like to provide my fork as an official source but to be honest, all I am doing here is trial&error most of the time as I am not exactly a master of vimscript. But I am willing to offer my code base to whoever feels more appropriate to maintain a vim plugin.

[rodrigobdz]

Just in case nobody more qualified steps forward: I have recently forked the excellent, but unmaintained (the most up to date fork just integrates pending pull requests) vim-fish and started updating it (private branch, not pushed yet). I’m sure I am not the most qualified person to do so, but I would be willing to maintain it, or a syntax subset, for the Vim runtime if nobody else does.

The link provided in the comment is broken. Would love to see Fish syntax highlighting in vim.

[MarcinOrlowski]

Seems @kopischke gave up as I am unable to find anything related vim-fish among his public repos.

[kopischke]

@MarcinOrlowski whoops, yes, sorry, I should have stated that but thought @wilriker would pick up the torch; my bad, this was not me at my best. I never pushed my half assed fork as RL has taken me away from regular Vim use, so consider me out of the equation. Again, apologies for not stating this clearly earlier.

[nickeb96]

I'd like to put my vim plugin for fish up as a candidate. The syntax highlighting is more accurate and consistent compared to other plugins I've seen. Also, it very closely matches how fish natively highlights interactive commands and output of the type builtin.

I will happily be a maintainer for these files and update them as fish changes and adds new features. I also haven't selected a license yet, so I can use the vim license if that helps.

The only question I have is how I go about submitting them. Do I just make a pull request with my additions? I couldn't find any relevant info on adding new runtime files in CONTRIBUTING.md.

[brammool]

I'd like to put [my vim plugin for fish](https://github.com/nickeb96/fish.vim) up as a candidate. The syntax highlighting is more accurate and consistent compared to other plugins I've seen. Also, it very closely matches how fish natively highlights interactive commands and output of the `type` builtin.

I don't know Fish, I'll let others comment on whether this syntax file is a good choice.

I will happily be a maintainer for these files and update them as fish changes and adds new features. I also haven't selected a license yet, so I can use the vim license if that helps.

Using the Vim license avoids trouble distributing the whole package. It is defenitely good to have an active maintainer.

The only question I have is how I go about submitting them. Do I just make a pull request with my additions? I couldn't find any relevant info on adding new runtime files in [CONTRIBUTING.md](https://github.com/vim/vim/blob/master/CONTRIBUTING.md).

You can create a PR, that gives others a chance to have a look and make comments. If that is too complicated you can also email me the files.

…

-- From "know your smileys": :-) Funny |-) Funny Oriental (-: Funny Australian /// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[nickeb96]

The fish runtime files above are now in vim as of this commit: 938ae28

It looks like someone with admin rights can close complete this issue.

[chrisbra]

closing then