Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert culling of "Autodesk" substring in data fields #243

Open
1 task
mavimaec opened this issue Nov 29, 2022 · 5 comments
Open
1 task

Revert culling of "Autodesk" substring in data fields #243

mavimaec opened this issue Nov 29, 2022 · 5 comments
Assignees

Comments

@mavimaec
Copy link
Contributor

mavimaec commented Nov 29, 2022

TODO

The "Autodesk" substring is currently being culled when the product and version are presented in the data fields. For the purposes of reflecting the data "as-is" from the VIM file, we should not perform this culling.

@SamuelAB-VIM
Copy link

@mavimaec
I want to minimize the mention of Autodesk where unnecessary
I understand you would like me to leave the strings alone

If you judge the effort to reward to be inappropriate, you can revert this design change as it is not a showstopper

@mavimaec
Copy link
Contributor Author

I want to minimize the mention of Autodesk where unnecessary

Could you expand on why you feel this way?

@SamuelAB-VIM
Copy link

I don't want to give them free marketing where we already mention Revit

@mavimaec
Copy link
Contributor Author

I can empathize with your viewpoint. Nonetheless, from a technical standpoint, I suggest we revert the culling to ensure that the data displayed is as close as possible to the data contained in the VIM file.

@SamuelAB-VIM
Copy link

You have my blessings to reinstate the sanctity of the pure data 📿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants