Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why skip_if_no_vault_test_server #31

Closed
maelle opened this issue Oct 23, 2020 · 2 comments
Closed

why skip_if_no_vault_test_server #31

maelle opened this issue Oct 23, 2020 · 2 comments

Comments

@maelle
Copy link
Contributor

maelle commented Oct 23, 2020

This function defined in a test helper file doesn't seem to be used anywhere or am I missing something?

@richfitz
Copy link
Member

richfitz commented Oct 24, 2020

Looks like it is just stale; now we start the test server with

vault_test_server()

which includes a check for things like the server being present and the user having opted in to using it (details). The if_disabled argument to vault_test_server defaults to testthat::skip which does the actual skipping now.

That function can be deleted safely, will do that next time I do some maintenance on this package :)

@richfitz
Copy link
Member

richfitz commented Jun 8, 2021

that function is now removed

@richfitz richfitz closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants