Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

referrer querystring is gone after an error #226

Closed
timc13 opened this issue Mar 22, 2018 · 4 comments
Closed

referrer querystring is gone after an error #226

timc13 opened this issue Mar 22, 2018 · 4 comments
Assignees
@luwes
Labels
bug Something isn't working player

Comments

@timc13
Copy link

timc13 commented Mar 22, 2018

Expected Behavior

After an error occurs with loadVideo, any subsequent loadVideo fails because of privacy settings.
I suspect this is because although the app_id querystring parameter is passed, the referrer querystring is now missing.

Actual Behavior

If one video errors while loading, it should not stop other videos from loading.

Steps to Reproduce

  1. call loadVideo on an existing video ID. Notice referrer in the querystring
  2. call loadVideo on a non-existent video ID. This should throw an error that can be safely caught.
  3. call loadVideo on the existing video ID again. Notice referrer is NOT in the querystring anymore.
@luwes luwes added bug Something isn't working player labels Mar 27, 2018
@timc13
Copy link
Author

timc13 commented Mar 30, 2018

may be related to #166

@luwes luwes self-assigned this Jun 15, 2018
@luwes
Copy link
Contributor

luwes commented Jun 18, 2018

this should be resolved! please let us know if you see otherwise. thanks

@luwes luwes closed this as completed Jun 18, 2018
@timc13
Copy link
Author

timc13 commented Jun 22, 2018

hi can you point to the PR or release that fixed this ?

@luwes
Copy link
Contributor

luwes commented Jun 22, 2018

@timc13 sorry, it was an internal player issue so we can't provide that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
bug Something isn't working player
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timc13 @luwes