Fix #1580 - look for no-returns in try/catch statements

src/Psalm/Internal/Analyzer/Statements/Block/TryAnalyzer.php

@@ -291,6 +291,13 @@ function ($fq_catch_class) use ($codebase) {
 
             $statements_analyzer->analyze($catch->stmts, $catch_context);
 
+            // recalculate in case there's a no-return clause
+            $catch_actions[$i] = ScopeAnalyzer::getFinalControlActions(
+                $catch->stmts,
+                $codebase->config->exit_functions,
+                $context->inside_case
+            );
+
             foreach ($issues_to_suppress as $issue_to_suppress) {
                 if (!in_array($issue_to_suppress, $suppressed_issues, true)) {
                     $statements_analyzer->removeSuppressedIssues([$issue_to_suppress]);

tests/ReturnTypeTest.php

@@ -563,7 +563,7 @@ public function foo() {
 
                     class B extends A {
                         /**
-                         * @return no-return
+                         * @return never-returns
                          */
                         public function foo() {
                             exit();

tests/TryCatchTest.php

@@ -205,6 +205,22 @@ function doTry() : void {
                         }
                     }',
             ],
+            'noReturnInsideCatch' => [
+                '<?php
+                    /**
+                     * @return never-returns
+                     */
+                    function example() : void {
+                        throw new Exception();
+                    }
+
+                    try {
+                        $str = "a";
+                    } catch (Exception $e) {
+                        example();
+                    }
+                    ord($str);'
+            ],
         ];
     }