Always evaluate property calls on mixed methods

vimeo · Jul 12, 2019 · 7f0dcae · 7f0dcae
1 parent 1208437
commit 7f0dcae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
@@ -585,6 +585,7 @@ private static function evaluateAribitraryParam(
             || $arg->value instanceof PhpParser\Node\Expr\StaticCall
             || $arg->value instanceof PhpParser\Node\Expr\Assign
             || $arg->value instanceof PhpParser\Node\Expr\ArrayDimFetch
+            || $arg->value instanceof PhpParser\Node\Expr\PropertyFetch
             || $arg->value instanceof PhpParser\Node\Expr\Array_
         ) {
             if (ExpressionAnalyzer::analyze($statements_analyzer, $arg->value, $context) === false) {

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -590,6 +590,17 @@ function foo($a) : void {
                     }',
                 'error_message' => 'UndefinedMethod',
             ],
+            'complainAboutUndefinedPropertyOnMixedCall' => [
+                '<?php
+                    class C {
+                        /** @param mixed $a */
+                        public function foo($a) : void {
+                            /** @psalm-suppress MixedMethodCall */
+                            $a->bar($this->d);
+                        }
+                    }',
+                'error_message' => 'UndefinedThisPropertyFetch',
+            ],
         ];
     }
 }