Fix unused ref in assign op

Fixes #1968
vimeo · Jul 24, 2019 · e22e0ac · e22e0ac
1 parent ed61bca
commit e22e0ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php
@@ -847,6 +847,7 @@ public static function analyzeAssignmentRef(
 
         if ($lhs_var_id) {
             $context->vars_in_scope[$lhs_var_id] = Type::getMixed();
+            $context->hasVariable($lhs_var_id, $statements_analyzer);
         }
 
         if ($rhs_var_id) {

diff --git a/tests/UnusedVariableTest.php b/tests/UnusedVariableTest.php
@@ -1002,6 +1002,13 @@ function foo(?A $a) : void {
                         }
                     }',
             ],
+            'varPassedByRef' => [
+                '<?php
+                    function foo(array $b) : void {
+                        $a = &$b;
+                        $a["foo"] = 5;
+                    }',
+            ],
         ];
     }