Possibly Null Argument in bcdiv() scale

[TheDevick]

This Code:

<?php

class Math
{
    public function __construct(
        public readonly ?int $scale = null
    ) {
    }

    /**
     * @param numeric-string $x
     * @param numeric-string $y
     *
     * @return numeric-string
     */
    public function div(string $x, string $y): string
    {
        return bcdiv($x, $y, $this->scale);
    }
}

In the bcdiv() docs, we can see that the scale can be Nullable

• Psalm Version: 5.14.1

[psalm-github-bot]

Hey @TheDevick, can you reproduce the issue on https://psalm.dev ?

[TheDevick]

Hey @TheDevick, can you reproduce the issue on https://psalm.dev ?

https://psalm.dev/r/336a0f7530

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/336a0f7530

<?php

class Math
{
    public function __construct(
        public readonly ?int $scale = null
    ) {
    }

    /**
     * @param numeric-string $x
     * @param numeric-string $y
     *
     * @return numeric-string
     */
    public function div(string $x, string $y): string
    {
        return bcdiv($x, $y, $this->scale);
    }
}

Psalm output (using commit 73ebe22):

ERROR: PossiblyNullArgument - 18:30 - Argument 3 of bcdiv cannot be null, possibly null value provided

[weirdan]

Feel free to submit the PR, the change would be around these lines:

psalm/stubs/CoreGenericFunctions.phpstub

Lines 1357 to 1364 in dc81630

	/**
	* @psalm-pure
	*
	* @param numeric-string $num1
	* @param numeric-string $num2
	* @return (PHP_MAJOR_VERSION is 8 ? numeric-string : ($num2 is "0" ? null : numeric-string))
	*/
	function bcdiv(string $num1, string $num2, int $scale = 0): ?string {}