Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream_socket_shutdown & socket_shutdown call is not used #10235

Closed
ghost opened this issue Sep 28, 2023 · 2 comments · Fixed by #10244
Closed

stream_socket_shutdown & socket_shutdown call is not used #10235

ghost opened this issue Sep 28, 2023 · 2 comments · Fixed by #10244
Labels
easy problems Issues that can be fixed without background knowledge of Psalm good first issue Help wanted

Comments

@ghost
Copy link

ghost commented Sep 28, 2023

Hello!

An error is reported for the following two functions:

  • stream_socket_shutdown
  • socket_shutdown

The error is:
UnusedFunctionCall - The call to socket_shutdown is not used (see https://psalm.dev/206)
UnusedFunctionCall - The call to stream_socket_shutdown is not used (see https://psalm.dev/206)

This is wrong, since both functions can be used without doing anything with the returned result.

Thank you.
@psalm-github-bot
Copy link

Hey @LauraTaylorUK, can you reproduce the issue on https://psalm.dev ?

@orklah orklah added easy problems Issues that can be fixed without background knowledge of Psalm Help wanted good first issue labels Sep 30, 2023
@orklah
Copy link
Collaborator

orklah commented Sep 30, 2023

This can be fixed by adding those here:
https://github.com/vimeo/psalm/blob/db07b05156d3a5f65e09000999acb6ae47f05634/dictionaries/ImpureFunctionsList.php

@tuqqu tuqqu mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy problems Issues that can be fixed without background knowledge of Psalm good first issue Help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add stream_socket_shutdown socket_shutdown to impure function list tuqqu/psalm
1 participant
@orklah