Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

literal-string is non-empty-string seems to be considered as always true #10926

Open
VincentLanglet opened this issue Apr 28, 2024 · 1 comment · May be fixed by #10927
Open

literal-string is non-empty-string seems to be considered as always true #10926

VincentLanglet opened this issue Apr 28, 2024 · 1 comment · May be fixed by #10927
Labels

Comments

@VincentLanglet
Copy link
Contributor

Similar to #10911

The reproducer can be https://psalm.dev/r/e9071d2408

Copy link

I found these snippets:

https://psalm.dev/r/e9071d2408
<?php

/**
 * @return (
 *    $s is non-empty-string ? float : int
 * )
 */
function foo(string $s) {
    return 1.0; // Obviously wrong
}

/** @var literal-string $b */
$b
/** @psalm-trace $a */
$a = foo($b);

/** @var string $b */
$b
/** @psalm-trace $a */
$a = foo($b);
Psalm output (using commit 08afc45):

ERROR: ParseError - 15:1 - Syntax error, unexpected T_VARIABLE on line 15

ERROR: ParseError - 20:1 - Syntax error, unexpected T_VARIABLE on line 20

INFO: UnusedParam - 8:21 - Param s is never referenced in this method

INFO: Trace - 15:1 - $a: float

INFO: Trace - 20:1 - $a: float|int

INFO: UnusedVariable - 15:1 - $a is never referenced or the value is not used

INFO: UnusedVariable - 20:1 - $a is never referenced or the value is not used

@weirdan weirdan added the bug label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants