Uncaught InvalidArgumentException: $class cannot be empty

[iluuu1994]

Running psalm 3.4.0 on our beautiful legacy code base causes the following error:

$ psalm --no-cache --debug-by-line

Scanning 💩/vendor/phpoffice/phpexcel/Classes/PHPExcel/Chart/Axis.php
PHP Notice:  Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/CommentAnalyzer.php on line 307

Notice: Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/CommentAnalyzer.php on line 307
PHP Notice:  Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 907

Notice: Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 907
PHP Notice:  Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 908

Notice: Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 908
PHP Notice:  Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 910

Notice: Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 910
PHP Notice:  Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 948

Notice: Uninitialized string offset: 0 in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 948
PHP Fatal error:  Uncaught InvalidArgumentException: $class cannot be empty in 💩/vendor/vimeo/psalm/src/Psalm/Type.php:984
Stack trace:
#0 💩/vendor/vimeo/psalm/src/Psalm/Type.php(966): Psalm\Type::getFQCLNFromString('', Object(Psalm\Aliases))
#1 💩/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2367): Psalm\Type::fixUpLocalType('', Object(Psalm\Aliases), Array, Array)
#2 💩/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2080): Psalm\Internal\Visitor\ReflectorVisitor->improveParamsFromDocblock(Object(Psalm\Storage\MethodStorage), Array, Object(PhpParser\Node\Stmt\ClassMethod), false)
#3 💩/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(256): Psalm\Internal\Visitor\ReflectorVisitor->registerFunctionLike(Object(PhpParser\Node\Stmt\ClassMethod))
#4 /Users/ilijatovilo/Developer/s in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 984

Fatal error: Uncaught InvalidArgumentException: $class cannot be empty in 💩/vendor/vimeo/psalm/src/Psalm/Type.php:984
Stack trace:
#0 💩/vendor/vimeo/psalm/src/Psalm/Type.php(966): Psalm\Type::getFQCLNFromString('', Object(Psalm\Aliases))
#1 💩/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2367): Psalm\Type::fixUpLocalType('', Object(Psalm\Aliases), Array, Array)
#2 💩/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2080): Psalm\Internal\Visitor\ReflectorVisitor->improveParamsFromDocblock(Object(Psalm\Storage\MethodStorage), Array, Object(PhpParser\Node\Stmt\ClassMethod), false)
#3 💩/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(256): Psalm\Internal\Visitor\ReflectorVisitor->registerFunctionLike(Object(PhpParser\Node\Stmt\ClassMethod))
#4 /Users/ilijatovilo/Developer/s in 💩/vendor/vimeo/psalm/src/Psalm/Type.php on line 984

Not sure if phpoffice/phpexcel/Classes/PHPExcel/Chart/Axis.php just happens to be the last file or if the issue is caused by that file.

3.3.2 works fine.

[weirdan]

What version of phpexcel is that? 1.8.0 (that's probably older than you have) doesn't cause a crash here.

[iluuu1994]

It's PHPExcel 1.8.2. Fixing it to 1.8.0 really does solve the problem.

[weirdan]

Looks like this:

/**
 * @param * $reference
 */

could be the culprit. Reproduced on psalm.dev: https://psalm.dev/r/989785059b

[muglug]

@iluuu1994 does the fix work for you?

[iluuu1994]

Yes! Thanks @muglug and @weirdan!

[XedinUnknown]

Same thing, with this file