Using the splat operator on a variable given to a function with a variadic parameter have incorrect side effects

[LeSuisse]

I would not have expected to get an error on https://psalm.dev/r/2196ad3688

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/2196ad3688

<?php

function takeVariadicInts(int ...$inputs): void
{
    print_r($inputs);
}

/**
 * @param non-empty-list<int> $inputs
 */
function takeNonEmptyList(array $inputs): void
{
    print_r($inputs);
}

$a = [3, 5, 7];
takeVariadicInts(...$a);
takeNonEmptyList($a);

Psalm output (using commit 951b943):

ERROR: ArgumentTypeCoercion - 18:18 - Argument 1 of takeNonEmptyList expects non-empty-list<int>, parent type array<int, int(3)> provided

[LeSuisse]

Thanks for the quick fix @muglug! I'm not sure it completely fixes the issue, see https://psalm.dev/r/da8bc6d1d5

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/da8bc6d1d5

<?php

/**
 * @return non-empty-list<int>
 */
function provide(): array
{
    return [3, 5, 7];
}

function takeVariadicInts(int ...$inputs): void
{
    print_r($inputs);
}

/**
 * @param non-empty-list<int> $inputs
 */
function takeNonEmptyList(array $inputs): void
{
    print_r($inputs);
}

$a = provide();
takeVariadicInts(...$a);
takeNonEmptyList($a);

Psalm output (using commit da170ef):

ERROR: ArgumentTypeCoercion - 26:18 - Argument 1 of takeNonEmptyList expects non-empty-list<int>, parent type array<int, int> provided

[muglug]

made better in 9cd8170