mb_strtolower|upper does not return false

[vudaltsov]

https://psalm.dev/r/d499c196d5
https://www.php.net/manual/en/function.mb-strtolower.php
I can fix this tomorrow.

I was also surprised that the second example in the snippet passes. @muglug , is that okay?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d499c196d5

<?php

/**
 * @param list<string> $values
 */
function checkStrings(array $values): void {}

checkStrings(array_map('mb_strtolower', ['a']));



function checkString(string $value): void {}

checkString(mb_strtolower('a'));

Psalm output (using commit 07e5250):

INFO: UnusedParam - 6:29 - Param $values is never referenced in this method

ERROR: InvalidScalarArgument - 8:14 - Argument 1 of checkStrings expects list<string>, array{0: false|string} provided

INFO: UnusedParam - 12:29 - Param $value is never referenced in this method

[weirdan]

mb_strtolower|upper does not return false

It does in 7.4.5: https://github.com/php/php-src/blob/php-7.4.5/ext/mbstring/mbstring.c#L3532 (though the exact conditions are not clear to me right away).
And it doesn't in master: https://github.com/php/php-src/blob/master/ext/mbstring/mbstring.c#L2788

[orklah]

Seems like this was fixed since?

[weirdan]

@vudaltsov reopen if necessary.

[mpesari]

Hey, these functions have indeed changed since PHP 8 to not return false, but throw instead:

7.4.20: https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_strtolower_error2.phpt
8.0.0: https://github.com/php/php-src/blob/php-8.0.0/ext/mbstring/tests/mb_strtolower_error2.phpt

Maybe this could be fixed by adding the new signatures to the dictionaries/CallMap_80_delta.php file?

Could be useful to check the whole mbstring family while at it.

[weirdan]

Maybe this could be fixed by adding the new signatures to the dictionaries/CallMap_80_delta.php file?

Yes, PR is welcome 😄