Switch regression?

[vudaltsov]

https://psalm.dev/r/6614a43b21

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6614a43b21

<?php

/**
 * @psalm-immutable
 * @template T of self::READ_UNCOMMITTED|self::READ_COMMITTED|self::REPEATABLE_READ|self::SERIALIZABLE
 */
final class TransactionIsolationLevel
{
    private const READ_UNCOMMITTED = 'read uncommitted';
    private const READ_COMMITTED = 'read committed';
    private const REPEATABLE_READ = 'repeatable read';
    private const SERIALIZABLE = 'serializable';

    /**
     * @psalm-var T $level
     */
    private string $level;

    /**
     * @psalm-param T $level
     */
    private function __construct(string $level)
    {
        $this->level = $level;
    }

    /**
     * @psalm-return self<self::READ_UNCOMMITTED>
     */
    public static function readUncommitted(): self
    {
        return new self(self::READ_UNCOMMITTED);
    }

    /**
     * @psalm-return self<self::READ_COMMITTED>
     */
    public static function readCommitted(): self
    {
        return new self(self::READ_COMMITTED);
    }

    /**
     * @psalm-return self<self::REPEATABLE_READ>
     */
    public static function repeatableRead(): self
    {
        return new self(self::REPEATABLE_READ);
    }

    /**
     * @psalm-return self<self::SERIALIZABLE>
     */
    public static function serializable(): self
    {
        return new self(self::SERIALIZABLE);
    }

    /**
     * @psalm-return T
     */
    public function toString(): string
    {
        return $this->level;
    }

    /**
     * @psalm-template TResult
     * @psalm-param callable(self::READ_UNCOMMITTED): TResult $readUncommitted
     * @psalm-param callable(self::READ_COMMITTED): TResult $readCommitted
     * @psalm-param callable(self::REPEATABLE_READ): TResult $repeatableRead
     * @psalm-param callable(self::SERIALIZABLE): TResult $serializable
     * @psalm-return TResult
     */
    public function resolve(
        callable $readUncommitted,
        callable $readCommitted,
        callable $repeatableRead,
        callable $serializable
    ) {
        switch ($this->level) {
            case self::READ_UNCOMMITTED:
                return $readUncommitted($this->level);

            case self::READ_COMMITTED:
                return $readCommitted($this->level);

            case self::REPEATABLE_READ:
                return $repeatableRead($this->level);

            case self::SERIALIZABLE:
                return $serializable($this->level);

            default:
                throw new \LogicException(sprintf('Level "%s" is an invalid transaction isolation level.', $this->level));
        }
    }
}

Psalm output (using commit 21e5678):

ERROR: PossiblyInvalidArgument - 83:41 - Argument 1 expects string(read uncommitted), possibly different type T:TransactionIsolationLevel as string(read committed)|string(read uncommitted)|string(repeatable read)|string(serializable) provided

ERROR: PossiblyInvalidArgument - 86:39 - Argument 1 expects string(read committed), possibly different type T:TransactionIsolationLevel as string(read committed)|string(read uncommitted)|string(repeatable read)|string(serializable) provided

ERROR: PossiblyInvalidArgument - 89:40 - Argument 1 expects string(repeatable read), possibly different type T:TransactionIsolationLevel as string(read committed)|string(read uncommitted)|string(repeatable read)|string(serializable) provided

ERROR: PossiblyInvalidArgument - 92:38 - Argument 1 expects string(serializable), possibly different type T:TransactionIsolationLevel as string(read committed)|string(read uncommitted)|string(repeatable read)|string(serializable) provided

[muglug]

narrowed to https://psalm.dev/r/321fb79d3f (without switch, but with ==)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/321fb79d3f

<?php

/**
 * @psalm-immutable
 * @template T of self::READ_UNCOMMITTED|self::READ_COMMITTED|self::REPEATABLE_READ|self::SERIALIZABLE
 */
final class TransactionIsolationLevel
{
    private const READ_UNCOMMITTED = 'read uncommitted';
    private const READ_COMMITTED = 'read committed';
    private const REPEATABLE_READ = 'repeatable read';
    private const SERIALIZABLE = 'serializable';

    /**
     * @psalm-var T $level
     */
    private string $level;

    /**
     * @psalm-param T $level
     */
    private function __construct(string $level)
    {
        $this->level = $level;
    }

    /**
     * @psalm-return self<self::READ_UNCOMMITTED>
     */
    public static function readUncommitted(): self
    {
        return new self(self::READ_UNCOMMITTED);
    }

    /**
     * @psalm-return T
     */
    public function toString(): string
    {
        return $this->level;
    }

    /**
     * @psalm-template TResult
     * @psalm-param callable(self::READ_UNCOMMITTED): TResult $readUncommitted
     * @psalm-return TResult
     */
    public function resolve(callable $readUncommitted) {
        if ($this->level == self::READ_UNCOMMITTED) {
            return $readUncommitted($this->level);
        }
        
        throw new \LogicException(sprintf('Level "%s" is an invalid transaction isolation level.', $this->level));
    }
}

Psalm output (using commit 21e5678):

ERROR: PossiblyInvalidArgument - 50:37 - Argument 1 expects string(read uncommitted), possibly different type T:TransactionIsolationLevel as string(read committed)|string(read uncommitted)|string(repeatable read)|string(serializable) provided