Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taint analysis resulting in possible duplicates? #3773

Closed
prabhu opened this issue Jul 8, 2020 · 2 comments
Closed

Taint analysis resulting in possible duplicates? #3773

prabhu opened this issue Jul 8, 2020 · 2 comments

Comments

@prabhu
Copy link

prabhu commented Jul 8, 2020

Repo used: https://github.com/prabhu/YetiForceCRM/

taint-php-report.fmt.json.txt

Notice how entries such as File app/ConfigFile.php line 246 is getting repeated multiple times. This change should have happened in the last few times. This repo used to receive 23 results but now getting 133 indicating possible duplicates.

@psalm-github-bot
Copy link

Hey @prabhu, can you reproduce the issue on https://psalm.dev ?

@muglug
Copy link
Collaborator

muglug commented Jul 8, 2020

Hey, I don't believe there are any duplicates – what's happening now is that the same sink is allowed to have multiple results in the output, if there were a number of different ways for tainted data to travel to it.

@muglug muglug closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants