Unexpected RedundantConditionGivenDocblockType

[andyg0808]

It seems like the conditional here is a reasonable thing to do:
https://psalm.dev/r/b4f8169f97

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b4f8169f97

<?php

/**
 * @template T of mixed|false|null
 * @param T $i
 * @return (T is false ? no-return : T is null ? no-return : T)
 */
function orThrow($i) {
    if ($i === false || $i === null) {
        throw new RuntimeException("Example");
    }
    return $i;
}

/** @psalm-trace $var */
$var = orThrow(false);

Psalm output (using commit d1ca68e):

ERROR: RedundantConditionGivenDocblockType - 9:9 - Found a redundant condition when evaluating docblock-defined type $i and trying to reconcile type 'T:fn-orthrow as false|mixed|null' to !false

INFO: LessSpecificReturnType - 6:12 - The inferred return type 'T' for orThrow is more specific than the declared return type 'T|never-return'

ERROR: NoValue - 16:1 - This function or method call never returns output

[weirdan]

Also, types inferred in ifs here look incorrect: https://psalm.dev/r/eca2491cf6

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/eca2491cf6

<?php

/**
 * @template T of mixed|false|null
 * @param T $i
 * @return (T is false ? no-return : (T is null ? no-return : T))
 */
function orThrow($i) {
    /** @psalm-trace $i */
    $i;
    
    if ($i === false) {
        /** @psalm-trace $i */
        $i;
        throw new RuntimeException("Example");
    }
    if ($i === null) {
        /** @psalm-trace $i */
        $i;
        throw new RuntimeException("Example");
    }
    /** @psalm-trace $i */
    $i;
    return $i;
}

/** @psalm-trace $var */
$var = orThrow(false);

Psalm output (using commit d1ca68e):

INFO: Trace - 10:5 - $i: T:fn-orthrow as false|mixed|null

INFO: Trace - 14:9 - $i: T:fn-orthrow as false|mixed|null

INFO: Trace - 19:9 - $i: T:fn-orthrow as mixed|null

INFO: Trace - 23:5 - $i: T:fn-orthrow as mixed

INFO: LessSpecificReturnType - 6:12 - The inferred return type 'T' for orThrow is more specific than the declared return type 'T|never-return'

ERROR: NoValue - 28:1 - This function or method call never returns output