Initialization of private trait members is not detected by psalm

[danog]

Psalm cannot detect initialization of typed private trait properties, even when they are in fact indirectly initialized in the class constructor.

https://psalm.dev/r/d316318ce2

[weirdan]

@psalm-github-bot, resolve this: https://psalm.dev/r/d316318ce2

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d316318ce2

<?php

trait a
{
    private int $prop;
    public function m(int $prop): void {
        $this->prop = $prop;
    }
}

class b
{
    use a;
    public function __construct()
    {
        $this->m(1);
    }
}

Psalm output (using commit 1d077cc):

ERROR: PropertyNotSetInConstructor - 11:7 - Property b::$prop is not defined in constructor of b and in any private or final methods called in the constructor

[weirdan]

Just like with normal setters they need to be defined final: https://psalm.dev/r/18680465d4

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/18680465d4

<?php

trait a
{
    private int $prop;
    public final function m(int $prop): void {
        $this->prop = $prop;
    }
}

class b
{
    use a;
    public function __construct()
    {
        $this->m(1);
    }
}

Psalm output (using commit 1d077cc):

No issues!

[danog]

The same issue is present if the method is aliased: https://psalm.dev/r/d8caf723b2

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d8caf723b2

<?php

trait a
{
    private int $prop;
    public final function m(int $prop): void {
        $this->prop = $prop;
    }
}

class b
{
    use a {
        m as final pony;
    }
    public function __construct()
    {
        $this->pony(1);
    }
}

Psalm output (using commit eddd7b8):

ERROR: PropertyNotSetInConstructor - 11:7 - Property b::$prop is not defined in constructor of b and in any private or final methods called in the constructor