psalter --issues=MissingParamType adds duplicate @param annotations

[caugner]

I have observed several occurrences where psalter added duplicate @param annotations when there has already been an (invalid) @param annotation without a type. It would be nice if Psalm could reuse those annotations.

Before:

/**
 * @param $x
 */
function foo($x) {}

foo(true);
foo(false);

After:

/**
 * @param $x
 * @param bool $x
 */
function foo($x) {}

foo(true);
foo(false);

PS: This example is abstracted from what I observed.

[psalm-github-bot]

Hey @caugner, can you reproduce the issue on https://psalm.dev ?

[caugner]

Alternatively, @param $x should cause an InvalidDocblock issue:

https://psalm.dev/r/d560c42190

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d560c42190

<?php

/**
 * @param $x
 */
function foo($x) {}

Psalm output (using commit dda013d):

INFO: MissingParamType - 6:14 - Parameter $x has no provided type

INFO: MissingReturnType - 6:10 - Method foo does not have a return type, expecting void

[stejes]

I have the same issue, in my example:

     /**
     * @param null|string $search
     */
    private static function resolveFilter(string|null $search, array $columns, array &$errors): array

Both the typing in the phpdoc and the typing in the parameter list were absent before psalm --alter was run.

[orklah]

Fixed by #9441