Annotate "insert element" operation on TKeyedArray

[doggor]

I have a function that accept an TKeyedArray and insert a specific element into it. For example, given a input $arr which is in type of @template T of array{id: int} , after having operation like $arr['baz'] = 'baz'; the output should becomes T & array{'baz':string}.

https://psalm.dev/r/ef60918b5a

I found a similar issue #3339 that describes a more general situation, but don't know if there is a solution for this case.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/ef60918b5a

<?php

/**
 * @template T of array{id: int}
 *
 * @param T $arr
 * @param-out T&array{bar: string} $arr
 * @return void
 **/
function addBar(array &$arr): void {
    $arr['bar'] = 'bar';
}

$arr1 = ['id' => 1, 'foo' => 'foo'];
$arr2 = ['id' => 2, 'baz' => 'baz'];

addBar($arr1);
addBar($arr2);

Psalm output (using commit dda013d):

ERROR: InvalidDocblock - 10:1 - Intersection types must be all objects or all object-like arrays, Psalm\Type\Atomic\TKeyedArray provided in docblock for addBar

ERROR: ReferenceConstraintViolation - 10:24 - Variable $arr is limited to values of type T:fn-addbar as array{id: int} because it is passed by reference, (T:fn-addbar as array{id: int})|array{bar: string(bar)} type found. Use @param-out to specify a different output type

[weirdan]

At least the message is wrong, as TKeyedArray is what previously was called object-like array.

[weirdan]

I was referring to the

ERROR: InvalidDocblock - 10:1 - Intersection types must be all objects or all object-like arrays, Psalm\Type\Atomic\TKeyedArray provided in docblock for addBar

It's self-contradicting, as TKeyedArray is object-like array.

[orklah]

The message was changed, so this is no longer a bug, rather a enhancement