Fix array_key_exists() with all int literal keys #5197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://psalm.dev/r/a0e5cf2ff8)
When checking code like the following:
the
if
incheckNegated
would cause:This happens when the array keys are all int literals, but the "needle"
is a string.
array_key_exists()
uses a loose equality comparison, but the generatedassertions for this specific case
(
AssertionFinder::getArrayKeyExistsAssertions
) was generating strictequality clauses. This commit fixes it by changing the generated clause
from
=
to~
.