Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server lookup cache for file is corrupted when editing method #5297

Closed
muglug opened this issue Feb 28, 2021 · 3 comments
Closed

Language server lookup cache for file is corrupted when editing method #5297

muglug opened this issue Feb 28, 2021 · 3 comments

Comments

@muglug
Copy link
Collaborator

muglug commented Feb 28, 2021

To reproduce:

  1. Run ./psalm --clear-global-cache which clears the language server's cache
  2. Open VS Code with the Psalm plugin
  3. Open tests/AlgebraTest.php
  4. Notice all hovers, go-to-definition etc. work as intended
  5. Edit the body of the first method
  6. Notice that hovers, go-to-definition etc. in other methods no longer work
  7. Editing those other methods brings back hover and go-to-definition

cc @joehoyle as an FYI. This maybe didn't ever work? Not sure

@muglug
Copy link
Collaborator Author

muglug commented Feb 28, 2021

ah ok this was broken in #5084

@muglug muglug closed this as completed in ad82c93 Feb 28, 2021
@muglug
Copy link
Collaborator Author

muglug commented Feb 28, 2021

still a bit buggy

@muglug muglug reopened this Feb 28, 2021
@muglug
Copy link
Collaborator Author

muglug commented Feb 28, 2021

I think this is probably good to close again

@muglug muglug closed this as completed Feb 28, 2021
This was referenced Mar 15, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant