Fix oci8 stubs for PHP 8

[morozov]

As of php/php-src@74ca2a3, the OCI-Lob and OCI-Collection classes are named as OCILob and OCICollection respectively.

This is related to #5465 but fixes the issue only on PHP 8 and only when the extension is loaded. If I add the difference between PHP 8 and PHP 7.4 to the stubs and run Psalm with php-version=7.3, it will start failing on PHP 8. Fixing this issue is out of the scope of this PR.

It looks like apart from stubbing method signatures, Psalm should stub the OCI-/OCI classes if the runtime version is different from the analyzer version:

if (PHP_VERSION_ID >= 80000 && $codebase->php_major_version < 8) {
    class OCI-Lob { /* ... */}
}

if (PHP_VERSION_ID < 80000 && $codebase->php_major_version >= 8) {
    class OCILob { /* ... */}
}

[muglug]

Thanks! Please also update the callmap delta! https://github.com/vimeo/psalm/blob/2b1bced09f0dd1a3e72cae86209a3d1353fcf46a/dictionaries/CallMap_80_delta.php

[morozov]

@muglug please see the description:

If I add the difference between PHP 8 and PHP 7.4 to the stubs and run Psalm with php-version=7.3, it will start failing on PHP 8.

[muglug]

Oh OK sorry. I hate that bloody hyphen.