Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the environment variable for using Shepherd #5512

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

ngmy
Copy link
Contributor

@ngmy ngmy commented Mar 29, 2021

I want to be able to specify whether or not to use Shepherd by the environment variable.

I use a Composer script to run lint in both my local and CI environments (Github Actions):

"scripts":
    "lint": [
        "@phpcs",
        "@psalm"
    ],
    "phpcs": "@php tools/phpcs ...",
    "psalm": "@php tools/psalm ...",
}

I would be happy if it could be specified by the environment variable, so that I don't have to write scripts that only differ in the presence or absence of the --shepherd option:

- name: Run lint
  env:
      PSALM_SHEPHERD: 1
      run: composer lint

or

- name: Run lint
  env:
      PSALM_SHEPHERD: 1
      PSALM_SHEPHERD_HOST: host
      run: composer lint

@weirdan weirdan merged commit 4c197af into vimeo:master Jul 16, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 16, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants