Improve type resolution of class constants. #5591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle array plus operator (fixes vimeo#5588). Handle array spread operator. Improve string concatenation to resolve to literal instead of unknown string. I feel like it should be possible to let ConstantTypeResolver take advantage of the better type analysis in ArrayAnalyzer, ConcatAnalyzer, etc, but it would require a restructuring that's beyond me for the time being.
AndrolGenhald
commented
Apr 7, 2021
Comment on lines
-1167
to
+1182
| ClassLikeAnalyzer::VISIBILITY_PUBLIC, | ||
| $stmt->isProtected() | ||
| ? ClassLikeAnalyzer::VISIBILITY_PROTECTED | ||
| : ($stmt->isPrivate() | ||
| ? ClassLikeAnalyzer::VISIBILITY_PRIVATE | ||
| : ClassLikeAnalyzer::VISIBILITY_PUBLIC), |
There was a problem hiding this comment.
Not quite sure if I'm fixing a mistake or introducing a bug here. I think it fixes a mistake, since it looks like these are existing constants for the current class, but none of the tests are affected either way, so I'm not sure exactly what affect this has.
There was a problem hiding this comment.
This is unnecessary — these constants are not actually used, but it's a harmless change so it's fine to keep.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle array plus operator (fixes #5588).
Handle array spread operator.
Improve string concatenation to resolve to literal instead of unknown string.
I feel like it should be possible to let ConstantTypeResolver take advantage of the better type analysis in ArrayAnalyzer, ConcatAnalyzer, etc, but it would require a restructuring that's beyond me for the time being.