Assert intersection type when two variables are compared #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
commented
May 15, 2021
| @@ -596,10 +596,6 @@ public static function checkPropertyVisibility( | |||
| return $emit_issues ? null : true; | |||
|
|
|||
| case self::VISIBILITY_PROTECTED: | |||
| if ($appearing_property_class === $context->self) { | |||
There was a problem hiding this comment.
This condition was flagged as redundant by this PR because it was previously checked here: https://github.com/vimeo/psalm/pull/5774/files#diff-218a87ce16087e317b1d9c674f9998fc9617b722fb0eeaa6d09c4d54032d7dbdL559
EDIT: no, it's not anymore. I removed it after it was flagged by a wrong fix for this PR, it's not reported anymore with the current fix. However, it still seem coherent so we may as well get rid of it
There was a problem hiding this comment.
Seems fine, it was added many eons ago and I can well believe it's redundant
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4687. When two variables are compared, it asserts the narrowest common type for both variables.