Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform bad offsets #5817

Merged
merged 2 commits into from May 23, 2021
Merged

Transform bad offsets #5817

merged 2 commits into from May 23, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented May 23, 2021

This fixes #4894 in two ways:

  • It transforms any literal float to a literal int instead of just an int on ArrayAnalyzer
  • It transforms any bad offset to an acceptable offset in ArrayFetchAnalyzer

I'm not completely satisfied by the fix however, the two objects each detects bad offsets with a different code. I just added the transformation in between. This may be refactored later to extract the common code and use the same detection

@muglug muglug merged commit 350df11 into vimeo:master May 23, 2021
@muglug
Copy link
Collaborator

muglug commented May 23, 2021

Thanks!

@orklah orklah deleted the transformFloatOffsets branch September 14, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect definition of the array type
2 participants