Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Enrich taint details for outputting core stubs #5827

Merged
merged 1 commit into from
May 24, 2021

Conversation

ohader
Copy link
Contributor

@ohader ohader commented May 24, 2021

Affects taint behavior or PHP core functions printf, print_r, var_dump, var_export.
This change does not change nor introduce conditional taint sinks as discussed in issue #4669.

Affects `printf`, `print_r`, `var_dump`, `var_export`
@muglug muglug merged commit 4898cd2 into vimeo:master May 24, 2021
@muglug
Copy link
Collaborator

muglug commented May 24, 2021

Thanks!

@ohader ohader deleted the outputting-stubs branch May 24, 2021 20:59
ohader added a commit to ohader/psalm that referenced this pull request May 26, 2021
Affects `printf`, `print_r`, `var_dump`, `var_export`
/**
* @param mixed $var
* @param bool $return
* @return ($return is true ? string : true)
*
* @psalm-taint-specialize
* @psalm-flow ($var) -> return
* @psalm-taint-sink html $var
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #3744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants