Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Allow plugins to declare their custom scanner or analyzer #5883

Merged
merged 7 commits into from
Jun 4, 2021
Merged

[FEATURE] Allow plugins to declare their custom scanner or analyzer #5883

merged 7 commits into from
Jun 4, 2021

Conversation

ohader
Copy link
Contributor

@ohader ohader commented Jun 3, 2021 •
edited

Fix: #5882

@ohader ohader marked this pull request as draft June 3, 2021 14:31
@ohader
Copy link
Contributor Author

ohader commented Jun 3, 2021

  • Psalm self-test will fail, since new methods are not used - I was reluctant modifying existing RegistrationInterface - maybe there might be a new FileTypeRegistrationInterface (not sure about the name)
  • documentation is missing - will take care
  • probably some test cases would be nice as well

@muglug
Copy link
Collaborator

muglug commented Jun 3, 2021

Psalm self-test will fail, since new methods are not used

That will be fixed if you add tests!

@weirdan
Copy link
Collaborator

weirdan commented Jun 3, 2021

I was reluctant modifying existing RegistrationInterface

It should be fairly safe to expand that. Third-party code is not expected to implement that interface, plugin authors should only consume it.

@ohader
Copy link
Contributor Author

ohader commented Jun 3, 2021

I was reluctant modifying existing RegistrationInterface

It should be fairly safe to expand that. Third-party code is not expected to implement that interface, plugin authors should only consume it.

Nice, just spotted this comment. Will extend the interface later...

@ohader ohader marked this pull request as ready for review June 3, 2021 17:34
@ohader
[!!!][TASK] Extend Psalm\Plugin\RegistrationInterface
bf65ba8 
* add method `addFileTypeScanner(string $fileExtension, string $className): void`
* add method `addFileTypeAnalyzer(string $fileExtension, string $className): void`
@ohader
[TASK] Ignore IntelliJ/PhpStorm workspace folder in VCS
cd21e26
@ohader
[TASK] Remove superfluous class import
e3aa979
ohader
ohader commented Jun 3, 2021
View reviewed changes
.gitignore Show resolved Hide resolved
@muglug muglug merged commit e457a7d into vimeo:master Jun 4, 2021
@muglug
Copy link
Collaborator

muglug commented Jun 4, 2021

Thanks!

@ohader ohader deleted the issue-5882 branch February 20, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow plugins to declare their additional scanners or analyzers
3 participants
@ohader @muglug @weirdan