Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6013, implement workspace/didChangeWatchedFiles #6014

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

tm1000
Copy link
Contributor

@tm1000 tm1000 commented Jun 29, 2021

This implements workspace/didChangeWatchedFiles

We also check to make sure the watch file that was changed is not currently open so this technically depends on #6010 being merged otherwise the files aren't tracked and there will be conflicts

Co-authored-by: Bruce Weirdan <weirdan@gmail.com>
@tm1000
Copy link
Contributor Author

tm1000 commented Jun 29, 2021

@weirdan it would still be nice to be able to get this merged in even though it will at some point in the future require a register call to function. Without the register call it won't break functionality.

The reason is that one of the older static analysis tools for php vscode was removed by Microsoft from the marketplace because it was no longer updated and caused stability issues. The maintainer of that is the same maintainer of the RPC and language server dependencies that Psalm itself uses.

Namely: https://github.com/felixfbecker/php-language-server and https://github.com/felixfbecker/php-language-server-protocol (@muglug seems to at least have access to the second one)

This pr actually brings Psalm almost to feature parity with the extension that was disabled from the marketplace. I'm linking that extensions issue list so you can see what I'm talking about: https://github.com/felixfbecker/vscode-php-intellisense/issues

@weirdan weirdan merged commit 0196afc into vimeo:master Jun 29, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jun 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants